Re: [libvirt] [PATCH 1/2] build: don't use "test cond1 -o cond2": it's not portable
Eric Blake wrote:
* configure.ac: Use "test cond1 || test cond2" instead.
* m4/compiler-flags.m4 (gl_COMPILER_FLAGS): Likewise.
* tests/test-lib.sh (verbose): Likewise.
---
Is it worth reformatting any of the lines that now exceed 80 columns?
I debated the same thing and ended up splitting one line.
FWIW, I used this to perform the conversion,
perl -pi -e 's/\b(test .+) -o (.*)/$1 || test $2/'
but had to run it 3 times to convert the line with three -o's.
Don't bother revising. I'll push this as-is,
but we should eventually split all long lines in configure.ac.
configure.ac | 32 ++++++++++++++++----------------
m4/compiler-flags.m4 | 5 +++--
tests/test-lib.sh | 2 +-
3 files changed, 20 insertions(+), 19 deletions(-)