Re: [libvirt] [PATCH] virCommand: Extend debug message for handshake

On 05/30/2012 06:20 AM, Michal Privoznik wrote: > Currently, we are logging only one side of pipes we > create in virCommandRequireHandshake(); This is enough > in cases where pipe2() returns two consecutive FDs. However, > it is not guaranteed and it may return any FDs. > Therefore, it's wise to log the other ends as well. > --- > src/util/command.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/util/command.c b/src/util/command.c > index eaa9f16..5b94f1e 100644 > --- a/src/util/command.c > +++ b/src/util/command.c > @@ -2443,8 +2443,10 @@ void virCommandRequireHandshake(virCommandPtr cmd) > return; > } > > - VIR_DEBUG("Transfer handshake wait=%d notify=%d", > - cmd->handshakeWait[1], cmd->handshakeNotify[0]); > + VIR_DEBUG("Transfer handshake wait=%d notify=%d, " > + "keep handshake wait=%d notify=%d", > + cmd->handshakeWait[1], cmd->handshakeNotify[0], > + cmd->handshakeWait[0], cmd->handshakeNotify[1]); ACK; this has no other impact other than a useful debug aid.