Re: [libvirt] [PATCH 1/4] conf: use virXMLFormatElement for <iommu><driver>
On 08/29/2017 12:48 PM, Ján Tomko wrote:
Use the new helper to simplify the code.
This also fixes the bug of not formatting 'eim' in the useless
case if it's the only enabled attribute.
---
src/conf/domain_conf.c | 55 ++++++++++++++++++++++++++++----------------------
1 file changed, 31 insertions(+), 24 deletions(-)
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John
If I didn't read patch4, I might have said in a here that perhaps
tests/qemuxml2argvdata/qemuxml2argv-intel-iommu-eim.xml should be
modified to remove "intremap='on' " - good thing I read ahead! ;-)