Re: [libvirt] [RFC] [PATCH 1/3 v3] vepa+vsi: Introduce dependency on libnl

On 05/25/2010 02:34 PM, Stefan Berger wrote: > On Tue, 2010-05-25 at 11:58 -0600, Eric Blake wrote: > >> On 05/24/2010 06:24 AM, Stefan Berger wrote: >> >>> @@ -283,6 +289,10 @@ BuildRequires: yajl-devel >>> %if %{with_libpcap} >>> BuildRequires: libpcap-devel >>> %endif >>> +%if %{with_libnl} >>> +BuildRequires: libnl-devel >>> +Requires: libnl >>> +%endif >>> >> Correction - it was pointed out to me on IRC that the 'Requires: libnl' >> line is not necessary (compare with the libpcap segment above) - the rpm >> build process will automatically picks up any Requires dependencies >> discovered during .so tracing. If you haven't pushed yet, then adjust >> that one line. >> > I haven't pushed it but will remove the line. Still waiting for an ACK > on the patch. > > Stefan > I considered the ACK in Eric's previous message as binding. If one isn't enough, then I'll ACK as well, since I've been using it and it's doing the right thing. (BTW, in case you didn't see my message on IRC, the other patches are being reviewed right now, so should be ready for push RSN)