Re: [libvirt] [PATCH 2/4] snapshot: conf: Avoid dereferencing NULL snapshot parent
On 01/21/2013 03:53 AM, Peter Krempa wrote:
> I'm slightly against this patch as I prefer a crashing daemon
to silent
> propagation of bug.
Hm, yeah. I agree. The snapshot metaroot patch that caused this problem
expects that all snapshots except the metaroot have parents so this may
disclose other potential bugs.
Hmm, I wonder if the real bug is that we somehow earlier managed to
create a snapshot without setting the metaroot as its initial parent.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)