Re: [libvirt] [PATCH] Fix vm define error with back compat console device

Daniel Veillard <veillard(a)redhat.com&gt; wrote: > On Fri, Jan 16, 2009 at 12:09:33AM +0000, Daniel P. Berrange wrote: >> On Thu, Jan 15, 2009 at 10:17:56PM +0100, Jim Meyering wrote: >>> "Daniel P. Berrange" <berrange(a)redhat.com&gt; wrote: >>> ... >>>>> + virsh --connect qemu:///session define devs.xml >>>> Shouldn't use qemu:///session for test cases like this - this is what >>>> the test:///default driver is for, avoiding the fragility & danger of >>>> using the daemon & live hypervisor drivers. >>> There's no failure with test:///default. >> I'm rather surprised at that - both drivers use identical XML formating >> routines here, so given the same config, both should fail just as badly. >> Is this perhaps a case where we need to run it under valgrind to make >> it reliably fail. > Maybe that can be debugged separately, I would like to see the > patch fixed, maybe we can isolate the problem in the test driver (if > any) but it should not block the initial patch from being commited, Cole, can you commit your fix?