Re: [libvirt] [PATCH 3/8] docs: Add docs and rng schema for new XML cdbfilter

On 12/14/2012 01:33 PM, Eric Blake wrote: This table shows another reason why I don't like your naming - the defaults are screwy, when an omitted rawio means 'no', but an omitted cdbfilter means 'yes'. Corrected, the table looks like: rawio cdbfilter result missing missing kernel prevents SG_IO missing no SG_IO allowed for disk missing yes kernel prevents SG_IO no missing kernel prevents SG_IO no no error? or SG_IO allowed for disk? no yes error? or kernel prevents SG_IO? yes missing SG_IO allowed for process yes no error yes yes error? or kernel prevents SG_IO? Oh, another thing, what does 'cdb' mean? It happens to be an acronym that matches the kernel implementation, but it doesn't convey much meaning on its own. Given that our existing rawio='yes' merely turns on SG_IO via a capability for the entire process, and the new filtering method enables per-disk whitelisting of which disks get to use SG_IO passthrough, would it be any better to document things as: no|yes|disk and where we additionally allow 'process' as a synonym for 'yes' on input (for back-compat, we have to output 'yes', not 'process'). That is, I don't know that exposing the term 'cdb' buys us any understanding into what is really going on. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org