Re: [libvirt] Entering freeze for libvirt-1.0.5
On Fri, Apr 26, 2013 at 04:56:01PM +0200, Viktor Mihajlovski wrote:
On 04/26/2013 04:44 PM, Ján Tomko wrote:
>On 04/26/2013 04:35 PM, Ján Tomko wrote:
>>
>>Are you able to start it after you delete the PCI address from the USB
>>controller in the XML? (in this case, qemuAssignDevicePCISlots will just
>>assign it without checking if there's a PCI bus available)
>>
>
>Disregard that, it would get added there anyway.
>
>I'll do my best to post a patch today
>
>Jan.
>
Please check out the patch I just sent. It works for me and
should be good enough until we find a better way to disable
the implicit USB->PCI device creation.
No, it is not good enough. We must never add hardware to the XML
description that does not exist in the actual VM being launched.
By adding a PCI root to the s390, you create a timebomb which
will change guest ABI if libvirt ever starts honouring that
PCI root config in the future.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|