Re: [libvirt] [PATCHv2 18/27] xen: reject unknown flags

2011/7/8 Eric Blake <eblake(a)redhat.com&gt;: > @@ -1629,8 +1633,10 @@ xenDaemonDomainSave(virDomainPtr domain, const char *filename) > */ > static int > xenDaemonDomainCoreDump(virDomainPtr domain, const char *filename, > - unsigned int flags ATTRIBUTE_UNUSED) > + unsigned int flags) > { > + virCheckFlags(0, -1); > + > if ((domain == NULL) || (domain->conn == NULL) || (domain->name == NULL) || > (filename == NULL)) { > virXendError(VIR_ERR_INVALID_ARG, __FUNCTION__); Third time fooled by ATTRIBUTE_UNUSED. xenDaemonDomainCoreDump understands VIR_DUMP_LIVE and VIR_DUMP_CRASH.

> @@ -3151,10 +3160,12 @@ xenDaemonDomainMigratePrepare (virConnectPtr dconn, > int *cookielen ATTRIBUTE_UNUSED, > const char *uri_in, > char **uri_out, > - unsigned long flags ATTRIBUTE_UNUSED, > + unsigned long flags, > const char *dname ATTRIBUTE_UNUSED, > unsigned long resource ATTRIBUTE_UNUSED) > { > + virCheckFlags(0, -1); > + > /* If uri_in is NULL, get the current hostname as a best guess > * of how the source host should connect to us. Note that caller > * deallocates this string. This breaks virDomainMigrate, because *DomainMigratePrepare is called with the flags passed to virDomainMigrate, even if xenDaemonDomainMigratePrepare doesn't use this flags it has to accept all flags that the Xen driver understand in general form migration.