Re: [libvirt] [PATCH 2/2] configure: Make virt-host-validate optional
On Mon, 2016-04-11 at 10:48 +0200, Martin Kletzander wrote:
I haven't looked that much into it, but I don't think we
should put the
generated man pages into the dist, but rather the .pod files and that
are there by default, right? Could just removing the:
EXTRA_DIST += virt-host-validate.1
be enough to fix what Cole saw happen?
We want to ship the generated man pages so that users don't need
to have pod2man(1) installed on their system.
Anyway, the problem is just that a hunk got lost while shuffling
commits around. After squashing it in distcheck works again for
me.
Cheers.
diff --git a/tools/Makefile.am b/tools/Makefile.am
index ab37d70..560a9a5 100644
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -67,7 +67,6 @@ bin_SCRIPTS = virt-xml-validate virt-pki-validate
bin_PROGRAMS = virsh virt-admin
libexec_SCRIPTS = libvirt-guests.sh
dist_man1_MANS = \
- virt-host-validate.1 \
virt-pki-validate.1 \
virt-xml-validate.1 \
virsh.1 \
--
Andrea Bolognani
Software Engineer - Virtualization Team