Re: [libvirt] [PATCH v2 09/11] test-data: Qemu caps replies and xml for s390x qemu 2.7 and 2.8
On Fri, Dec 09, 2016 at 14:38:38 -0500, Jason J. Herne wrote:
From: "Collin L. Walling"
<walling(a)linux.vnet.ibm.com>
Expected Qemu replies for versions 2.7 and 2.8 from the s390x
Qemu binary.
Signed-off-by: Collin L. Walling <walling(a)linux.vnet.ibm.com>
Signed-off-by: Jason J. Herne <jjherne(a)linux.vnet.ibm.com>
---
.../qemucapabilitiesdata/caps_2.7.0.s390x.replies | 11999 +++++++++++++++++
tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 140 +
.../qemucapabilitiesdata/caps_2.8.0.s390x.replies | 13380 +++++++++++++++++++
tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 286 +
4 files changed, 25805 insertions(+)
create mode 100644 tests/qemucapabilitiesdata/caps_2.7.0.s390x.replies
create mode 100644 tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml
create mode 100644 tests/qemucapabilitiesdata/caps_2.8.0.s390x.replies
create mode 100644 tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml
I know it's going to be a little bit more work for you, but could you
generate and commit the replies before patch 3/11? The patch 3/11 will
then need to carry an update on caps_2.8.0.s390x.replies and the xml
files since we start using query-cpu-model-expansion and patch 4/11 will
update the caps_2.8.0.s390x.xml file with the probed host-model. That
way we can immediately see what the patch is doing.
And don't forget to squash patch 10/11 into the first one which
introduces the new replies.
Alternatively, you can add a single replies/xml combo per patch to make
the patches a bit smaller (i.e., there would be separate patches for
2.7.0 and 2.8.0 versions of QEMU).
Jirka