Re: [libvirt] [PATCH] virsh: improve send-key documentation

On 09/01/2011 08:41 AM, Daniel P. Berrange wrote: >On Wed, Aug 31, 2011 at 08:49:28AM -0600, Eric Blake wrote: >>The 'virsh man' description of send-key was incomplete and used the >>old style (literal 'optional name' instead of '[name]' metasyntax). >>Meanwhile, none of the other virsh help texts include examples, so >>I moved it out of virsh help and into the man page. >> >>* tools/virsh.pod (send-key): Give better details. >>* tools/virsh.c (info_send_key): Drop example from here. >>--- > >I think we have to describe the codesets a bit more too.... I like it. Do I need to post a v2 for review, or is this an ACK if I just merge your suggestions into my v1 before pushing?