Re: [libvirt] [PATCH V2] Do not drop kernel cmdline for xen pv domains

Kernel cmdline args can be passed to xen pv domains even when a bootloader is specified.  The current config-to-sxpr mapping ignores cmdline when bootloader is present. Since the xend sub-driver is used with many xen toolstack versions, this patch takes conservative approach of adding an else block to existing !def->os.bootloader, and only appends sxpr if def->os.cmdline is non-NULL. V2: Fix existing testcase broken by this patch and add new testcases ---

+++ b/tests/sexpr2xmldata/sexpr2xml-pv-bootloader-cmdline.xml @@ -0,0 +1,27 @@ +<domain type='xen' id='6'> +  <name>pvtest</name> +  <uuid>596a5d21-71f4-8fb2-e068-e2386a5c413e</uuid> +  <memory>430080</memory> +  <currentMemory>430080</currentMemory> +  <vcpu>2</vcpu> +  <bootloader>/usr/bin/pygrub</bootloader> +  <bootloader_args>-q</bootloader_args> +  <os> +    <type>linux</type> +    <cmdline> xenfb.video=8,1280,1024 </cmdline>