Re: [libvirt] [PATCHv2 1/2] Split out most of virDBusIsServiceEnabled
On 03/03/2014 08:55 PM, Eric Blake wrote:
On 03/03/2014 08:47 AM, Ján Tomko wrote:
> Introduce virDBusIsServiceInList which can be used to call other
> methods for listing services (ListNames), not just ListActivatableNames.
Nice refactoring.
>
> No functional change.
> ---
> src/util/virdbus.c | 26 ++++++++++++++++----------
> 1 file changed, 16 insertions(+), 10 deletions(-)
>
> +/**
> + * virDBusIsServiceEnabled:
> + * @name: service name
> + *
> + * Retruns 0 if service is available, -1 on fatal error, or -2 if service is not
available
...merely moved down. Please fix it while touching here :)
I've fixed the typo...
> + */
> +int virDBusIsServiceEnabled(const char *name)
Two-line formatting might be nice.
... but kept the single-line formatting since most of the file uses it.
My findings are cosmetic, so ACK whether you address them or not.
Thanks, pushed.
Jan
Attachments:
- signature.asc (application/pgp-signature — 836 bytes)