Re: [PATCH 10/10] remote: Pass 'mode' and 'socket' URI parameters to virt-ssh-helper
On Mon, Feb 06, 2023 at 10:16:58 +0100, Michal Privoznik wrote:
Even though we have split daemons for some time now, they are not
the default by far. We've made the change ~1.5 year ago (in
v7.5.0-rc1~35).
Therefore, we have some users that use 'mode=legacy' parameter in
their connection URI. But this parameter is not propagated to
virt-ssh-helper (and neither is the 'socket=...' parameter).
But now that virt-ssh-helper parses those URI parameters, we can
pass them onto the remote host.
This commit message would benefit more from the explanation of how the
parameters are stripped, so you can explain why it's needed to be
skipped.
Resolves: https://gitlab.com/libvirt/libvirt/-/issues/433
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/remote/remote_driver.c | 29 +++++++++++++++++++++++------
1 file changed, 23 insertions(+), 6 deletions(-)
Reviewed-by: Peter Krempa <pkrempa(a)redhat.com>