Re: [PATCH v2 00/13] resolve hangs/crashes on libvirtd shutdown
On Mon, Sep 07, 2020 at 10:12:08AM +0300, Nikolay Shirokovskiy wrote:
Pushed now. Thanx everyone for review.
Patch "[PATCH v2 05/13] rpc: add virNetDaemonSetShutdownCallbacks" does not
have mantainer
review but I guess it is ok as the patch is simple enough and it's API is used in
other
patches of series.
I would also want to note that crashes are still possible because not all threads
are joined on shutdown in qemu driver and other drivers. For example in qemu driver we
spawn a thread during fake reboot or on daemon startup we spawn threads for every
VM to reconnect. So I would like to continue to work on this issues. Is this considered
worth the effort? I realize these are rare corner cases, like daemon shutdown
immediately
after daemon start or daemon shutdown coincide with some domain reboot etc.
Personally I wouldn't spend time on such edge cases, as I feel there are
probably worse problems in libvirt needing attention first, but if you
want to send patches we would of course review them.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|