Re: [libvirt] [PATCH] schema: support 'default' cache mode
On 03/14/2016 06:40 AM, Ján Tomko wrote:
On Mon, Feb 29, 2016 at 04:26:25PM -0700, Jim Fehlig wrote:
> The docs claims the cache attribute of the disk <driver>
> element supports 'default' as one of its permissible values,
> but such configuration fails virt-xml-validate. Add 'default'
> as one of the cache attribute choices in domaincommon.rng.
>
> Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
> ---
> docs/schemas/domaincommon.rng | 1 +
> 1 file changed, 1 insertion(+)
>
ACK
Thanks. I'll push this patch in a bit.
Does this need a test case in any of the directories 'domainschematest'
uses?
I just noticed xlconfigdata is not included in the domainschematest directories.
I'll send a follow-up to fix that, but none of the configs have
cache='default'
since it would simply be omitted in the corresponding xl config. Should I add a
simple XML config containing cache='default' directly to doaminschemadata?
Regards,
Jim