Re: [libvirt] [PATCH] cpu: add 'amd-ssbd' and 'amd-no-ssb' CPU features (CVE-2018-3639)
On Thu, Jun 21, 2018 at 12:24:13PM +0200, Kashyap Chamarthy wrote:
On Thu, Jun 14, 2018 at 11:48:41AM +0100, Daniel P. Berrangé wrote:
[...]
> Note that neither amd-ssbd or amd-no-ssb will be reported by the kernel
> in /proc/cpuinfo. It knows about these CPUID bits and does the right thing,
> but doesn't report their existance as distinct flags in /proc/cpuinfo.
Since it isn't pushed yet, minor nit-pick: s/existance/existence/
Should the commit message be amended to mention that `/proc/cpuinfo`
will, confusingly enough, report 'ssbd' (for 'amd-ssbd')?
Maybe it's not so confusing if it will show up as 'ssbd' for all (Intel
/ AMD) processors. Useful for tooling to look for one flag across all
the processors.
[...]
--
/kashyap