Re: [libvirt] [PATCH v1 4/8] use virBitmap to store numa nodemask info.

On 08/30/2012 02:55 AM, Hu Tao wrote: If the bitmap is sparse, this argues that we might want a new helper function: /* If bit is -1, find the first set bit (if any); otherwise, find the next set bit after the given position. Return -1 if there are no further set bits. */ int virBitmapNextAfter(virBitmapPtr map, int bit); The loop would then be: int i = virBitmapNextAfter(ctrl->def->numatune.memory.nodemask, -1); while (i >= 0) { /* do stuff for bit i */ i = virBitmapNextAfter(ctrl->def->numatune.memory.nodemask, i); } Hmm, this usage says we named the function incorrectly. 'cmp' implies <0, 0, >0 for use in qsort; whereas you give only a bool, so I would name it virBitmapEqual(). -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org