Re: [Libvir] [PATCH] virterror Cleanups

On Tue, Nov 20, 2007 at 10:36:21AM +0000, Richard W.M. Jones wrote: > Daniel Veillard wrote: >> On Tue, Nov 20, 2007 at 03:02:09PM +0900, Saori Fukuta wrote: >>> Hi, >>> >>> The virsh command sometimes says wrong message that indicating where >>> the error is coming from. So I have some fixes for libvirt error. >>> * Add two number for virErrorDomain (virterror.h) >>> * Add six message indicating where it's coming from (virterror.c) >>> * Fix virErrorDomain number specified with __virRaiseError >>> (openvz_conf.c/openvz_driver.c/stats_linux.c/xm_internal.c) >> Thanks a lot for chasing and fixing those issues, this makes a lot >> of sense, applied and commited to CVS ! > Agreed +1, but I think that VIR_FROM_LINUX should be renamed to > VIR_FROM_STATS_LINUX. > > Should I make this change? Sure, fine by me.

> /me really must change the ocaml bindings to autogenerate these lists of > errors, otherwise the bindings crash when an unknown error is generated :-(