Re: [libvirt] [PATCH v2] maint: Update to latest gnulib
On 01/02/2018 11:23 PM, Eric Blake wrote:
From: Michal Privoznik <mprivozn(a)redhat.com>
Unfortunately, since gnulib's commit of 2c5d558745 there's an
unused parameter to stat_time_normalize() function which gnulib
developers don't want to fix yet [1]. Therefore, we have to work
around it by temporarily providing a downstream patch.
1: http://lists.gnu.org/archive/html/bug-gnulib/2018-01/msg00000.html
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
[eblake: use gnulib local diff, instead of #pragma]
Signed-off-by: Eric Blake <eblake(a)redhat.com>
---
v2: perhaps nicer than Michal's original suggestion, but I'd still
wait another day or two to see if my arguments on the upstream
gnulib thread can instead give us a better submodule commit to
update to that avoids the problem altogether.
---
.gnulib | 2 +-
bootstrap | 4 ++--
gnulib/local/lib/stat-time.h.diff | 13 +++++++++++++
3 files changed, 16 insertions(+), 3 deletions(-)
create mode 100644 gnulib/local/lib/stat-time.h.diff
Looks like gnulib can be fixed after all. I mean, both Jim an Paul
agreed with your patch for _GL_UNUSED. Therefore we can just update the
submodule after you push the gnulib fix.
Awesome, thanks for your help!
Michal