Re: [libvirt] [Qemu-devel] [PATCH 8/9] target-i386: Use "-" instead of "_" on all feature names
On Tue, May 10, 2016 at 17:19:51 +0200, Igor Mammedov wrote:
On Fri, 6 May 2016 15:11:31 -0300
Eduardo Habkost <ehabkost(a)redhat.com> wrote:
> This makes the feature name tables in feature_word_info all match
> the actual QOM property names we use.
>
> This will make the command-line interface more consistent,
> allowing the QOM property names to be used as "-cpu" arguments
> directly.
wouldn't that change output of '-cpu help',
can it break libvirt?
Don't worry, for any QEMU >= 1.2.0 libvirt uses only QMP commands when
probing capabilities. And currently we don't even parse feature names
anywhere, we only use feature names when constructing -cpu command line
and that parts seems to be covered by this patch.
Jirka