Re: [libvirt] [PATCH 1/4] QEMU guest agent support
On Fri, Jan 20, 2012 at 07:16:22PM +0100, Michal Privoznik wrote:
On 19.01.2012 23:18, Eric Blake wrote:
> On 01/17/2012 04:44 AM, Michal Privoznik wrote:
>> There is now a standard QEMU guest agent that can be installed
>> and given a virtio serial channel
>>
>> <channel type='unix'>
>> <source mode='bind'
path='/var/lib/libvirt/qemu/f16x86_64.agent'/>
[snip]
I am not sure we want this. Although I am not fully convinced by the
opposite. Thing is, I don't want to enable something by default because
users might have not noticed and things may break for them.
On the other hand, users will definitely benefit from this feature so
making it as easy as possible to enable is the right step.
My initial thought is to have simple one line element:
<guest_agent name="org.qemu.guest_agent.0"/>
with name defaulting to "org.qemu.guest_agent.0" so simply inserting
bare <guest_agent/> will turn everything on?
No, we don't want to go about inventing new syntax for that - the
very purpose of any <channel> element is to support a guest agent,
so it is pointless creating another <guest_agent> element.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|