Re: [libvirt] [PATCH 04/10] Fix crash on OOM in qemuDomainCCWAddressSetCreate()

From: "Daniel P. Berrange" <berrange(a)redhat.com&gt; If OOM occurs in qemuDomainCCWAddressSetCreate, it jumps to a cleanup block and frees the partially initialized object. It then mistakenly returns the address of the just free'd pointer instead of NULL. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index e6239c9..b20149b 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1275,7 +1275,7 @@ qemuDomainCCWAddressSetCreate(void) cleanup:

qemuDomainCCWAddressSetFree(addrs); - return addrs; + return NULL; } /*