Re: [libvirt] [PATCH v2] syntax-check: Add prohibit_space_in_label rule
On Mon, 2015-11-16 at 15:05 +0100, Martin Kletzander wrote:
> +# Allow for up to three spaces before the label: this is to
avoid running
> +# into situations where require_space_before_label is not applied, eg. a
> +# line matching ^[a-zA-Z0-9]+ :$
> +sc_prohibit_space_in_label:
> + @prohibit='^ ? ? ?[_a-zA-Z0-9]+ +:$$' \
I would prefer ' {0,3}' instead of ' ? ? ?', but just for reading
purposes. ACK either way
Pushed with the improvement you suggested and a small tweak
to the comment, thanks!
Cheers.
--
Andrea Bolognani
Software Engineer - Virtualization Team