Re: [libvirt] [PATCH] qemu: Fix shutdown regression

On Wed, Sep 21, 2011 at 10:43:32AM +0200, Jiri Denemark wrote: > The commit that prevents disk corruption on domain shutdown > (96fc4784177ecb70357518fa863442455e45ad0e) causes regression with QEMU > 0.14.* and 0.15.* because of a regression bug in QEMU that was fixed > only recently in QEMU git. The affected versions of QEMU do not quit on > SIGTERM if started with -no-shutdown, which we use to implement fake > reboot. Since -no-shutdown tells QEMU not to quit automatically on guest > shutdown, domains started using the affected QEMU cannot be shutdown > properly and stay in a paused state. > > This patch disables fake reboot feature on such QEMU by not using > -no-shutdown, which makes shutdown work as expected. However, > virDomainReboot will not work in this case and it will report "Requested > operation is not valid: Reboot is not supported with this QEMU binary". > > NB, the qemu capability is called QEMU_CAPS_NO_FAKE_REBOOT for backward > compatibility with running domains started by libvirtd that didn't have > this patch in. > --- > src/qemu/qemu_capabilities.c | 9 +++++++++ > src/qemu/qemu_capabilities.h | 1 + > src/qemu/qemu_command.c | 2 +- > src/qemu/qemu_driver.c | 6 ++++++ > 4 files changed, 17 insertions(+), 1 deletions(-) > > diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c > index 36f47a9..5b9e4a9 100644 > --- a/src/qemu/qemu_capabilities.c > +++ b/src/qemu/qemu_capabilities.c > @@ -136,6 +136,7 @@ VIR_ENUM_IMPL(qemuCaps, QEMU_CAPS_LAST, > "pci-ohci", > "usb-redir", > "usb-hub", > + "no-fake-reboot", > ); This should really be 'no-shutdown'. The reboot code is just one current potential user of that capability.