Re: [libvirt] [PATCH python v10] Expose virDomainInterfacesAddresses to python binding
On Wed, Mar 18, 2015 at 2:50 AM, Nehal J Wani <nehaljw.kkd1(a)gmail.com> wrote:
On Mon, Mar 16, 2015 at 8:25 PM, Daniel P. Berrange
<berrange(a)redhat.com> wrote:
> From: Nehal J Wani <nehaljw.kkd1(a)gmail.com>
>
> examples/Makefile.am:
> * Add new file domipaddrs.py
>
> examples/README:
> * Add documentation for the python example
>
> libvirt-override-api.xml:
> * Add new symbol for virDomainInterfacesAddresses
>
> libvirt-override.c:
> * Hand written python api
>
> Example:
> $ python examples/domipaddrs.py qemu:///system f18
> Interface MAC address Protocol Address
> lo 00:00:00:00:00:00 ipv4 127.0.0.1/8
> lo 00:00:00:00:00:00 ipv6 ::1/128
> eth3 52:54:00:20:70:3d ipv4 192.168.105.240/16
> eth3 52:54:00:20:70:3d ipv6 fe80::5054:ff:fe20:703d/64
> eth2 52:54:00:36:2a:e5 N/A N/A
> eth1 52:54:00:b1:70:19 ipv4 192.168.105.201/16
> eth1 52:54:00:b1:70:19 ipv4 192.168.201.195/16
> eth1 52:54:00:b1:70:19 ipv6 fe80::5054:ff:feb1:7019/64
> eth0 52:54:00:2e:45:ce ipv4 10.1.33.188/24
> eth0 52:54:00:2e:45:ce ipv6 2001:db8:0:f101::2/64
> eth0 52:54:00:2e:45:ce ipv6 fe80::5054:ff:fe2e:45ce/64
This example uses VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_LEASE, so the
commit message should be showing vnetX instead of ethX.
In addition to above,
(i) 'lo' won't be available with lease store.
(ii) fd00::/8 are private ipv6 ranges. Hence should not be visible
through --source lease
(iii) 'N/A' is not possible in case of lease option. The underlying
API guarantees that.
Similar problem is present in the commit log for
2f36e6944e6eb56a00e19fcd85ec8513461597c9, but I guess no body wants to
mess with git history.
--
Nehal J Wani
--
Nehal J Wani