Re: [libvirt] [PATCHv2 27/27] build: add syntax check for proper flags use

On 07/13/2011 07:35 AM, Matthias Bolte wrote: Hmm, as committed in 2/27, it checked '\<flags=%...'. If we remove the \< then it would also cover oflags, and that's probably a good change to make. I'll do it, and see what fallout it causes. I thought about this (independently, because I'm working on an O_DIRECT patch for iohelper), and my conclusion was that normally libvirtd and libvirt_iohelper are installed at the same time. However, there is indeed a window where: Older libvirtd is running, and you install the newer executables. Then the older libvirtd calls out to libvirt_iohelper, and executes the new one. That is, if you install a new libvirtd package, but don't restart the libvirtd daemon, then the new libvirt_iohelper must understand the syntax that will be handed it by the older still-running libvirtd. Therefore, my conclusion is that we can't change any existing command lines, but can only add new ones. Adding new could include using "0x" or "0" prefixes (the old code output decimal, so it is distinguishable, and the new iohelper command line would then be that much easier to understand if you browse /proc/nnn/ to learn the command line that iohelper is using). I'll look into that, as a separate patch. I already have to post a v2, so we'll get another round of review on this commit as well as the couple of fallout suggestions raised here. -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org