Re: [PATCH v4 1/7] migration/dirtyrate: Introduce virDomainDirtyRateInfo structure
Do you mean embed this api into domstats like "virsh domstats --dirtyrate"?
It's indeed a good idea in consideration of extensibility. I will try that in my next
version, however,
I have no idea about where to place my secondary options (--second, --calculate and
--query). Any suggestion?
PS: Here is my original design:
virsh getdirtyrate --domain <vm> [--calculate] [--query] [--seconds
<period>]
BR,
Hao
>
> This should be squashed with 2/7 and bits of 5/7 and 6/7 which modify this
> file. The key here is that public API should go into one patch, driver
> implementation into other - it's easier to backport patches this way.
Additionally I'm not sure how likely is that the data will be extened at
some point in the future, but using a struct is not extensible.
I'd suggest that this gets reported in the domain stats API
.