Re: [libvirt PATCH] meson: Fix yajl workaround
On Mon, Jan 10, 2022 at 08:06:25AM +0300, Roman Bolshakov wrote:
The fix helps, thanks!
Reviewed-by: Roman Bolshakov <r.bolshakov(a)yadro.com>
Tested-by: Roman Bolshakov <r.bolshakov(a)yadro.com>
FWIW, I've tried to figure out where it went broken and it turned out to
be in c32c5ca29ae. Newer meson is not related to the issue.
So you might want to add the tag:
Fixes: c32c5ca29ae ("meson: Use get_pkgconfig_variable('cflags')")
Great detective work! Seeing how I'm the one who broke it, it only
make sense that I would have to fix it :)
I've tweaked the commit message in light of your discovery and pushed
the fix.
I'm still utterly confused about how the CI job for macOS managed to
pass every single time even while yajl detection on the platform was
completely broken...
--
Andrea Bolognani / Red Hat / Virtualization