Re: [libvirt] [PATCH] openvzLoadDomains: don't ignore failing virUUIDFormat
Daniel Veillard wrote:
> Subject: [PATCH] openvzLoadDomains: don't ignore failing
virUUIDFormat
>
> * src/openvz/openvz_conf.c (openvzLoadDomains): Diagnose failure of
> virUUIDFormat.
> ---
> src/openvz/openvz_conf.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c
> index 51dbde5..a4aab1e 100644
> --- a/src/openvz/openvz_conf.c
> +++ b/src/openvz/openvz_conf.c
> @@ -908,7 +908,11 @@ static int
> openvzSetUUID(int vpsid){
> unsigned char uuid[VIR_UUID_BUFLEN];
>
> - virUUIDGenerate(uuid);
> + if (virUUIDGenerate(uuid)) {
> + openvzError(NULL, VIR_ERR_INTERNAL_ERROR,
> + "%s", _("Failed to generate UUID"));
> + return -1;
> + }
>
> return openvzSetDefinedUUID(vpsid, uuid);
> }
ACK,
Thanks. Pushed.