Re: [GSoC][PATCH v4 4/4] qemu_domainjob: introduce `privateData` for `qemuDomainJobInfo`
On Tue, Jul 14, 2020 at 10:25 PM Michal Privoznik <mprivozn(a)redhat.com> wrote:
On 7/14/20 5:14 PM, Prathamesh Chavan wrote:
> Currently, domainJobInfo also uses "stats" as one of the job specific
> parameters. To remove this dependency, a privateData structure is
> introduced.
>
> The plan is to even have this structure renamed as
> `virDomainJobInfoInternal` as there already exists a
> `virDomainJobInfo'.
I see. Well, I'm not that sure about virDomainJobInfoInternal (mostly
because this qemuDomainJobInfo structure looks too qemu specific).
How about moving it under qemuDomainJobObj privateData? I mean,
qemuDomainJobPrivate structure you propose in 3/4?
The qemuDomainJobInfo is surely quite qemu specific.
1. The libxl, for the purpose of storing jobinfo, uses the generic
`virDomainJobInfo` structure.
2. The qemuDomainJob stores two jobinfo at an instance: current and
completed. And due to this, it would be difficult to split the
structure, and store part of it in qemuDomainJob.
I'm still looking into how this can be tackled. Maybe now is the time
we decide on the way we want our future structure `virDomainJob` to
look like.
Thanks,
Prathamesh Chavan