Re: Patch Re: [Libvir] save and restore guest

Daniel P. Berrange wrote: > On Mon, Oct 08, 2007 at 04:27:00PM +0200, Farkas Levente wrote: >> Daniel P. Berrange wrote: >>> On Sat, Oct 06, 2007 at 02:29:39PM +0200, Farkas Levente wrote: >>>> hi, >>>> if i use xen with xendomain it's possible to save and restore guest >>>> state. if i use libvirt it's not working (at least by default with kvm). >>>> i mean if i stop or restart libvirtd all guests a stopped and even if i >>>> restart libvirtd i've to start all guests manually. imho this's a very >>>> essential feature. what is the reason this not working with libvirtd?: >>>> - this feature is missing from libvirtd? or >>> You can set KVM/QEMU guests to autostart with >>> >>> virsh autostart {NAME|ID|UUID} >> thanks, but go back to my first question. afais /etc/init.d/libvirtd >> simple kill libvirtd, but virsh has a command save/restore. wouldn't be >> it's much better to save guest's state on stop, restore on start in >> stead of start if there is a saved state. i can send a patch to the >> /etc/init.d/libvirtd, just would like to know is there any reason it's >> not that way? anyway xendomains do it in the save way. > The save/restore capability is currently only available in the KVM-ified > version of QEMU. We could make it try to save, and failing that destroy > the guest. The xendomains scripts isn't a good model to emulate though. > The autostart/kill functionality is part of the libvirt daemon itself. Any > save/restore capability would be best integrated there for those who like to save and restore guest at libvirtd stop and start i attached a patch we use to for it. it's based on xen's sripts. LIBVIRTD_AUTO_ONLY still not implemented but the sysconfig file already contains it. if you like to set the default behavior to the current then set LIBVIRTD_RESTORE to false. imho it'd be useful to include in the upstream libvirtd too.