Re: [libvirt] [PATCH 05/13] conf: utility to return alias of a controller based on type/index

On 05/05/2015 02:03 PM, Laine Stump wrote: > + > + contIndex = virDomainControllerFind(def, type, idx); > + if (contIndex < 0) { > + virReportError(VIR_ERR_INTERNAL_ERROR, > + _("Could not find %s controller with index %d " > + "required for device"), > + contTypeStr, idx); > + return NULL; > + } > + if (!def->controllers[contIndex]->info.alias) { > + virReportError(VIR_ERR_INTERNAL_ERROR, > + _("Device alias was not set for %s controller " > + "with index %d "), > + contTypeStr, idx); > + return NULL; So if the alias wasn't set for some reason we're going to start seeing errors. Is there a reason the alias wouldn't be set... (just trying to think/type outloud later in the day at the end of the week as my brain is beginning to check out).