Re: [PATCH v2 3/7] hyperv: implement domainReboot and domainReset
On Wednesday, 14 October 2020 05:23:21 CEST Matt Coleman wrote:
> Note that virDomainReboot() can take various flags, however none
is
> used ATM.
Would it be okay to stick with what I’ve got, now, and look at adding
support for the flags in a future commit?
Sorry, I did not express myself properly: I did not want to say you
have to add support for these flags, but merely that the functions
implemented by this patch do not. Hence, depending on what you plan to
add to them (or even whether any of the flags can be supported), my
earlier suggestion of a common helper might make sense or not.
--
Pino Toscano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)