Re: [libvirt] [PATCH] qemu: Add cmd_per_lun, max_sectors to virtio-scsi
On 16:06 Thu 22 May , Eric Blake wrote:
On 05/22/2014 12:22 PM, Mike Perez wrote:
> This introduces two new attributes "cmd_per_lun" and
"max_sectors" same
> with the names QEMU uses for virtio-scsi. An example of the XML:
>
> <controller type='scsi' index='0' model='virtio-scsi'
cmd_per_lun='50'
> max_sectors='512'/>
I'm not a fan of underscore (why type the shift key, when a dash will
do). The libvirt xml name does not have to exactly match the qemu
option name, so maybe there's some room for bikeshedding what names we
should actually present to the user.
Thanks Eric. I posted v2 patch up which fixes the tab issues and switches the
option names from underscores to dashes.
--
Mike Perez