Re: [libvirt] [PATCH] macvtap.c: add parenthesis for similar expressions

On 02/03/2011 11:41 AM, Stefan Berger wrote: >> Actually, you've uncovered a bigger bug, but didn't fix it right. > > ohoh, yes, there's a bug. This is how it should look like > > --- > src/util/macvtap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Index: libvirt-acl/src/util/macvtap.c > =================================================================== > --- libvirt-acl.orig/src/util/macvtap.c > +++ libvirt-acl/src/util/macvtap.c > @@ -1048,8 +1048,8 @@ doPortProfileOpSetLink(bool nltarget_ker > > memcpy(ifla_vf_mac.mac, macaddr, 6); > > - if (!nla_put(nl_msg, IFLA_VF_MAC, sizeof(ifla_vf_mac), > - &ifla_vf_mac) < 0) > + if (nla_put(nl_msg, IFLA_VF_MAC, sizeof(ifla_vf_mac), > + &ifla_vf_mac) < 0) > goto buffer_too_small; ACK.