Re: [libvirt] [PATCH v3 1/3] numatune: add check for numatune nodeset range

On Wed, 2014-10-29 at 14:20 +0100, Martin Kletzander wrote: > On Wed, Oct 29, 2014 at 08:33:32PM +0800, Chen Fan wrote: > >diff --git a/src/util/virnuma.c b/src/util/virnuma.c > >@@ -373,6 +400,12 @@ virNumaGetNodeCPUs(int node ATTRIBUTE_UNUSED, > > _("NUMA isn't available on this host")); > > return -1; > > } > >+ > >+bool > >+virNumaNodesetIsAvailable(virDomainNumatunePtr numatune) > >+{ > >+ return true; > >+} > > #endif > > > > In what case would you like this to return true? when libvirt does not support numa, we can not check it. maybe we should return false if setting nodeset.