Re: [libvirt] [PATCH] qemu: Avoid holding the driver lock in trivial snapshot API's

In most of the snapshot API's there's no need to hold the driver lock the whole time. This patch adds helper functions that get the domain object in functions that don't require the driver lock and simplifies call paths from snapshot-related API's. --- src/conf/domain_conf.c | 3 +- src/qemu/qemu_driver.c | 306 +++++++++++++++---------------------------------- 2 files changed, 94 insertions(+), 215 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 4aa08d0..2e1c86b 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -14372,7 +14372,8 @@ void virDomainObjLock(virDomainObjPtr obj) void virDomainObjUnlock(virDomainObjPtr obj) { - virMutexUnlock(&obj->lock); + if (obj) + virMutexUnlock(&obj->lock); }