Re: [libvirt] [PATCH 08/14] driver: add option to make missing drivers a fatal problem
On 04/19/2018 07:09 PM, Daniel P. Berrangé wrote:
Currently the driver module loading code does not report an error if
the
driver module is physically missing on disk. This is useful for distro
packaging optional pieces. When the daemons are split up into one daemon
per driver, we will expect module loading to always succeed. If a driver
is not desired, the entire daemon should not be installed.
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
src/driver.c | 37 ++++++++++++++++++++++++++-----------
src/driver.h | 6 ++++--
src/remote/remote_daemon.c | 2 +-
src/storage/storage_backend.c | 9 +--------
tests/virdrivermoduletest.c | 2 +-
5 files changed, 33 insertions(+), 23 deletions(-)
ACK with this squashed in:
diff --git i/src/security/virt-aa-helper.c w/src/security/virt-aa-helper.c
index a1bc1090bf..ee5e3b0701 100644
--- i/src/security/virt-aa-helper.c
+++ w/src/security/virt-aa-helper.c
@@ -964,7 +964,7 @@ get_files(vahControl * ctl)
/* load the storage driver so that backing store can be accessed */
#ifdef WITH_STORAGE
- virDriverLoadModule("storage", "storageRegister");
+ virDriverLoadModule("storage", "storageRegister", false);
#endif
for (i = 0; i < ctl->def->ndisks; i++) {
Michal