Re: [libvirt] [PATCH] syntax-check: ignore all quoted strings in bracket-spacing
On 05/24/2013 03:26 AM, Ján Tomko wrote:
Ignore strings with an escaped double quote too.
This removes the need for special handling of quotes in the
semicolon check.
---
build-aux/bracket-spacing.pl | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
Hmm, our semicolon check enforces no leading spaces, but we could
probably improve it to also enforce trailing space in a for loop. For
example, this looks odd:
src/conf/interface_conf.c: for (i = 0; i < nbItf;i++) {
compared to
for (i = 0; i < nbItf; i++) {
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)