Re: [PATCH v2 2/6] rpc: Change return type of virNetServerAddProgram to void

This function return value is invariant since VIR_EXPAND_N check removal in 7d2fd6e, so change its type and remove all dependent checks. Found by Linux Verification Center (linuxtesting.org) with Svace. Reported-by: Pavel Nekrasov <p.nekrasov(a)fobos-nt.ru&gt; Signed-off-by: Alexander Kuznetsov <kuznetsovam(a)altlinux.org&gt; --- src/locking/lock_daemon.c | 10 ++-------- src/logging/log_daemon.c | 10 ++-------- src/remote/remote_daemon.c | 20 ++++---------------- src/rpc/virnetserver.c | 3 +-- src/rpc/virnetserver.h | 2 +- 5 files changed, 10 insertions(+), 35 deletions(-)

diff --git a/src/rpc/virnetserver.h b/src/rpc/virnetserver.h index 7756a1dd6c..c14d8bd10f 100644 --- a/src/rpc/virnetserver.h +++ b/src/rpc/virnetserver.h @@ -84,7 +84,7 @@ int virNetServerAddServiceUNIX(virNetServer *srv, size_t max_queued_clients, size_t nrequests_client_max); -int virNetServerAddProgram(virNetServer *srv, +void virNetServerAddProgram(virNetServer *srv, virNetServerProgram *prog);