On 03/17/2015 03:29 AM, Peter Krempa wrote:
On Mon, Mar 16, 2015 at 12:17:58 -0600, Eric Blake wrote:
>
https://bugzilla.redhat.com/show_bug.cgi?id=1199182 documents that
> after a series of disk snapshots into existing destination images,
> followed by active commits of the top image, it is possible for
> qemu 2.2 and earlier to end up tracking a different name for the
> image than what it would have had when opening the chain afresh.
> That is, when starting with the chain 'a <- b <- c', the name
> associated with 'b' is how it was spelled in the metadata of 'c',
> but when starting with 'a', taking two snapshots into 'a <- b <-
c',
> then committing 'c' back into 'b', the name associated with
'b' is
> now the name used when taking the first snapshot.
>
>
> v3: better sanity checks in qemu_monitor_json, rebase
> and retested atop Peter's fixes for interlocking block jobs
>
> src/qemu/qemu_driver.c | 28 ++++++------
> src/qemu/qemu_monitor.c | 20 ++++++++-
> src/qemu/qemu_monitor.h | 8 +++-
> src/qemu/qemu_monitor_json.c | 102 ++++++++++++++++++++++++++++++++++++++++++-
> src/qemu/qemu_monitor_json.h | 9 +++-
> 5 files changed, 149 insertions(+), 18 deletions(-)
ACK,
Thanks; pushed.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org