Re: [libvirt] [PATCH] conf: remove redundant ()

On 04/19/2012 04:21 PM, Eric Blake wrote: > I almost copied-and-pasted some redundant () into my new code, > and figured a general cleanup prereq patch would be better instead. > > * src/conf/domain_conf.c (virDomainLeaseDefParseXML) > (virDomainDiskDefParseXML, virDomainFSDefParseXML) > (virDomainActualNetDefParseXML, virDomainNetDefParseXML) > (virDomainGraphicsDefParseXML, virDomainVideoAccelDefParseXML) > (virDomainVideoDefParseXML, virDomainHostdevFind) > (virDomainControllerInsertPreAlloced, virDomainDefParseXML) > (virDomainObjParseXML, virDomainCpuSetFormat) > (virDomainCpuSetParse, virDomainDiskDefFormat) > (virDomainActualNetDefFormat, virDomainNetDefFormat) > (virDomainTimerDefFormat, virDomainGraphicsListenDefFormat) > (virDomainDefFormatInternal, virDomainNetGetActualHostdev) > (virDomainNetGetActualBandwidth, virDomainGraphicsGetListen): > Reduce extra (), per coding styles. Actually the libvirt coding style given in HACKING doesn't say anything about superfluous parentheses (not that I can find). Maybe you're thinking of coreutils, or gnulib?

I have one reservation, though - this is a lot of code churn, which increases the likelyhood of merge conflicts when backporting anything from future code to any recently rebased distro packages (unless you plan to backport this patch prior to any other backports). I guess it all comes down to whether you think the advantages of cleaner looking code outweighs potential time spent resolving extra conflicts (of course, if you think it's unlikely any bugfixes will need to be backported to any of this code, then that's a non-problem).