Re: [libvirt] [PATCH python] fix libvirt headers list
On 10/28/2014 11:30 AM, Dmitry Guryanov wrote:
On Tuesday 28 October 2014 11:15:20 Eric Blake wrote:
> On 10/28/2014 10:58 AM, Dmitry Guryanov wrote:
>> Since libvirt.h has been splitted out, generator.py
>
> s/splitted/split/
>
>> should be fixed accordingly. So add full list of header
>> files.
>
> Does this still work when targetting older libvirt prior to the header
> split? If so, then ACK.
Yes, it works, because "libvirt" is in the list.
I was more worried that it didn't gripe about missing files.
But re-reading the patch, it's always a membership lookup (is file in
list) and not a coverage (have we visisted all files in the list), so I
agree we are okay.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 539 bytes)