Re: [PATCH V2 0/4] Rework qemu internal active snapshots to use QMP
Hello everyone! This is a ping email
On 7/17/24 20:21, Nikolai Barybin wrote:
> Den, Peter, Daniel thank you for your comments!
>
> I'm sending v2 of this patchset.
>
> Changes since last revision:
>
> - dropped [PATCH 4/4] qemu monitor: reap qemu_monitor_text
>
> - added new patch: qemu capabilities: add QEMU_CAPS_SNAPSHOT_SAVE/_DELETE
>
> - preserved old-style snapshotting (HMP savevm) in case we have QEMU < 6.0
>
> - enhanced requirements for allowing snapshotting. All writable disks
> should be qcow2, non-shared. If such disks exist and we have qcow2
> NVRAM, add NVRAM device to the list of wrdevs. But never save vmstate
> to NVRAM
>
> - make char** wrdevs list allocation inside
> qemuSnapshotActiveInternalGetWrdevListHelper()
>
> Nikolai Barybin (4):
> qemu monitor: add snaphot-save/delete QMP commands
> qemu blockjob: add snapshot-save/delete job types
> qemu capabilities: add QEMU_CAPS_SNAPSHOT_SAVE/_DELETE
> qemu snapshot: use QMP snapshot-save/delete for internal snapshots
>
> src/qemu/qemu_block.c | 2 +
> src/qemu/qemu_blockjob.c | 6 +-
> src/qemu/qemu_blockjob.h | 2 +
> src/qemu/qemu_capabilities.c | 4 +
> src/qemu/qemu_capabilities.h | 2 +
> src/qemu/qemu_domain.c | 4 +
> src/qemu/qemu_monitor.c | 30 +++
> src/qemu/qemu_monitor.h | 13 ++
> src/qemu/qemu_monitor_json.c | 66 ++++++
> src/qemu/qemu_monitor_json.h | 13 ++
> src/qemu/qemu_snapshot.c | 207 ++++++++++++++++--
> .../caps_6.0.0_aarch64.xml | 2 +
> .../qemucapabilitiesdata/caps_6.0.0_s390x.xml | 2 +
> .../caps_6.0.0_x86_64.xml | 2 +
> .../caps_6.1.0_x86_64.xml | 2 +
> .../caps_6.2.0_aarch64.xml | 2 +
> .../qemucapabilitiesdata/caps_6.2.0_ppc64.xml | 2 +
> .../caps_6.2.0_x86_64.xml | 2 +
> .../caps_7.0.0_aarch64+hvf.xml | 2 +
> .../caps_7.0.0_aarch64.xml | 2 +
> .../qemucapabilitiesdata/caps_7.0.0_ppc64.xml | 2 +
> .../caps_7.0.0_x86_64.xml | 2 +
> .../qemucapabilitiesdata/caps_7.1.0_ppc64.xml | 2 +
> .../caps_7.1.0_x86_64.xml | 2 +
> tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml | 2 +
> .../caps_7.2.0_x86_64+hvf.xml | 2 +
> .../caps_7.2.0_x86_64.xml | 2 +
> .../caps_8.0.0_riscv64.xml | 2 +
> .../caps_8.0.0_x86_64.xml | 2 +
> .../qemucapabilitiesdata/caps_8.1.0_s390x.xml | 2 +
> .../caps_8.1.0_x86_64.xml | 2 +
> .../caps_8.2.0_aarch64.xml | 2 +
> .../caps_8.2.0_armv7l.xml | 2 +
> .../caps_8.2.0_loongarch64.xml | 2 +
> .../qemucapabilitiesdata/caps_8.2.0_s390x.xml | 2 +
> .../caps_8.2.0_x86_64.xml | 2 +
> .../qemucapabilitiesdata/caps_9.0.0_sparc.xml | 2 +
> .../caps_9.0.0_x86_64.xml | 2 +
> .../caps_9.1.0_x86_64.xml | 2 +
> 39 files changed, 391 insertions(+), 14 deletions(-)
>