Re: [libvirt] PATCH: Thread-safe error reporting public API
On Wed, Jan 07, 2009 at 11:49:11AM +0100, Daniel Veillard wrote:
On Fri, Dec 12, 2008 at 04:07:18PM +0000, Daniel P. Berrange wrote:
> On Fri, Dec 12, 2008 at 01:31:24PM +0100, Daniel Veillard wrote:
> > On Fri, Dec 12, 2008 at 10:51:33AM +0000, Daniel P. Berrange wrote:
> > > So I'll make the global virGetLastError() thread-safe, and then
there's
> > > no need for the new APIs, and also no need for anyone to call the
> > > virConnGetLastError(), though I'll make sure that still syncs to
> > > whatever error is stored in the global location anyway.
> >
> > okay, cool !
>
> Try out this patch. The virConn*Error methods are left as is, and the
> global vir*Error methods are made to use a thread local
Resurecting that old thread, I think this is still needed for 0.6.0
patch sounds fine to me, what about pushing it ?
I'm updating it a little. Some of it conflicts with the logging
changes, but more seriously it needed more fixes to work on
the Windows build. I'll post another version of the thread patches
as soon as I've got it working on Windows
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|