Re: [PATCH v2 0/4] cpu_map: Add EPYC-Rome model
On Wed, Oct 07, 2020 at 15:56:31 +0200, Markus Schade wrote:
Am 06.10.20 um 16:50 schrieb Jiri Denemark:
> But, since I don't really like going through the CPU model definition
> again (even though it would be just a diff), I can do these trivial
> changes just before pushing. Just let me know if you're OK with this and
> reply to my question in patch 2/4.
>
> And I apologize for incorrectly saying Ryzen 9 3900X should be EPYC
> (it's actually EPYC-Rome), which influenced my suggestion to not update
> Ryzen-9-3900X-12-Core.json with new models supported by QEMU. But don't
> worry, I'll do this myself as a follow-up patch since it is my fault.
Feel free to make any changes, you think are still necessary. If I
can/should do a v3, please let me know.
With the suggested changes
Reviewed-by: Jiri Denemark <jdenemar(a)redhat.com>
I squashed the patches in one, added the three missing features and
pushed the result.
Thanks.
Jirka