Re: [libvirt] [PATCH v2 08/12] qemu: drop unused code in qemuDomainGetJobStatsInternal
On Wed, Dec 28, 2016 at 17:39:17 +0300, Nikolay Shirokovskiy wrote:
Destination migration never fetch migration stats thus due
This becomes true only after patch 10/12.
to the check above fetch flag can not be set.
---
src/qemu/qemu_driver.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 913f8f3..84db59d 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -13037,12 +13037,6 @@ qemuDomainGetJobStatsInternal(virQEMUDriverPtr driver,
fetch = false;
if (fetch) {
- if (priv->job.asyncJob == QEMU_ASYNC_JOB_MIGRATION_IN) {
- virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
- _("migration statistics are available only on "
- "the source host"));
- return -1;
- }
With a combined knowledge of this patch and 10/12 I think it's better to
report this error on the destination host rather then successfully
returning statistics with everything but elapsed time equal to zero.
Jirka