Re: [libvirt] [PATCH v3 0/7] qemu: Introduce support for new the block_set_io_throttle parameters add in the version 1.7 of qemu.

On Thu, Sep 25, 2014 at 4:08 PM, Michal Privoznik <mprivozn(a)redhat.com&gt; wrote: > On 23.09.2014 16:13, Matthias Gatto wrote: >> >> This series of patches add support for bps_max, bps_rd_max, bps_wr_max, >> bps_max, bps_rd_max, bps_wr_max, and iops_size in the functions >> qemuDomainSetBlockIoTune and qemuDomainGetBlockIoTune. >> The last patch add support for these parameters to the virsh blkdeviotune >> command. >> >> v2: spellfix >> >> v3: Merge patch 1/9,2/9,5/9 together. >> Change the capability detection.(patch 2/7 and 3/7). >> Try to make the usage of QEMU_NB_BLOCK_IO_TUNE_PARAM_MAX more >> explicit(patch 3/7). >> >> Matthias Gatto (7): >> qemu: Add defines for the news throttle options and modify the >> structure _virDomainBlockIoTuneInfo. >> qemu: Add the capability to detect if the qemu binary have the >> capability to use bps_max and friends >> qemu: Add bps_max and friends qemu driver >> qemu: Add bps_max and friends QMP suport >> qemu: Add bps_max and friends "text" support >> qemu: add bps_max and friends to qemu command generation >> virsh: Add bps_max and friends to virsh >> >> include/libvirt/libvirt.h.in | 54 +++++++++++++++ >> src/conf/domain_conf.c | 89 +++++++++++++++++++++++- >> src/conf/domain_conf.h | 7 ++ >> src/qemu/qemu_capabilities.c | 4 ++ >> src/qemu/qemu_capabilities.h | 1 + >> src/qemu/qemu_command.c | 49 +++++++++++++ >> src/qemu/qemu_driver.c | 162 >> ++++++++++++++++++++++++++++++++++++++++--- >> src/qemu/qemu_monitor.c | 14 ++-- >> src/qemu/qemu_monitor.h | 6 +- >> src/qemu/qemu_monitor_json.c | 70 +++++++++++++++---- >> src/qemu/qemu_monitor_json.h | 6 +- >> src/qemu/qemu_monitor_text.c | 89 +++++++++++++++++++++--- >> src/qemu/qemu_monitor_text.h | 6 +- >> tests/qemumonitorjsontest.c | 6 +- >> tools/virsh-domain.c | 119 +++++++++++++++++++++++++++++++ >> tools/virsh.pod | 11 ++- >> 16 files changed, 643 insertions(+), 50 deletions(-) >> > > Interesting, you've sent the patches only two days ago, but I'm unable to > apply it cleanly. And what even more weird is that I had to go all the way > down to 1.2.7 release to apply your patches. Can you please rebase to the > current HEAD and resend? Be aware of Pavel's patches, esp. 18fc3199. > > Michal Ok i do it now. Sorry for the inconvenience.